Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): return userId from middleware #58

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

theboxer
Copy link
Contributor

The middleware doesn't return userId eventhough it's used in the action

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-safe-action-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 2:46pm
next-safe-action-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 2:46pm

@TheEdoRan
Copy link
Owner

LGTM, thank you for the fix. You just need to update and then force push the commit message with example as scope, instead of with-context, like this: fix(example): return userId from middleware. Using example as the scope will prevent the release of an unneeded library version on NPM when merging this PR, since it just fixes a bug in the example website. Thanks!

The middleware doesn't return userId eventhough it's used in the action
@theboxer theboxer force-pushed the fix-withcontext-example-app branch from b4bcb9b to 304e32c Compare January 31, 2024 14:45
@theboxer theboxer changed the title fix(with-context): return userId from middleware fix(example): return userId from middleware Jan 31, 2024
@theboxer
Copy link
Contributor Author

Adjusted :)

@TheEdoRan TheEdoRan merged commit 74f796b into TheEdoRan:main Jan 31, 2024
3 checks passed
Copy link

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 7.0.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants