Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ending comma/curlybrace after templateUrl optional. #67

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Riobe
Copy link

@Riobe Riobe commented Apr 27, 2017

I'm not sure if this is foolproof for all use cases this loaders is being used in. I've only tested it against my own app and saw it working. It simply makes the comma at the end of the line optional.

This will be a WIP until I get the tests passing.

If there are no downsides to this, then it should fix #50 and #58.

@codecov-io
Copy link

codecov-io commented Apr 27, 2017

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files           1        1           
  Lines          28       28           
  Branches        5        5           
=======================================
  Hits           27       27           
  Misses          1        1
Impacted Files Coverage Δ
index.js 96.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2dc887...df9ce1c. Read the comment docs.

@Riobe
Copy link
Author

Riobe commented Apr 27, 2017

Second commit changes the pull request to essentially switch the "match until you find a quote, double quote, or backtick" to "match until you find a quote, double quote, or backtick that doesn't follow a backslash".

This works for all the test cases and for my personal app. Any other suggestions would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(0.6.1) path problem
2 participants