-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the ending comma/curlybrace after templateUrl optional. #67
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 1 1
Lines 28 28
Branches 5 5
=======================================
Hits 27 27
Misses 1 1
Continue to review full report at Codecov.
|
Second commit changes the pull request to essentially switch the "match until you find a quote, double quote, or backtick" to "match until you find a quote, double quote, or backtick that doesn't follow a backslash". This works for all the test cases and for my personal app. Any other suggestions would be very welcome. |
I'm not sure if this is foolproof for all use cases this loaders is being used in. I've only tested it against my own app and saw it working. It simply makes the comma at the end of the line optional.
This will be a WIP until I get the tests passing.
If there are no downsides to this, then it should fix #50 and #58.