Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(macos): fix linker error #14

Merged
merged 4 commits into from
Nov 11, 2024
Merged

ci(macos): fix linker error #14

merged 4 commits into from
Nov 11, 2024

Conversation

TheLostLambda
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (64b8133) to head (800f7e1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files          15       15           
  Lines        4274     4274           
  Branches     4274     4274           
=======================================
  Hits         3260     3260           
  Misses        872      872           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheLostLambda TheLostLambda force-pushed the fix-macos-ci branch 8 times, most recently from f720950 to 58f3ef4 Compare November 8, 2024 15:50
@twop
Copy link

twop commented Nov 8, 2024

it seems that lld is not found(at least that is my interpretation of the CI error), I wonder if nee to be explicitly installed

@TheLostLambda
Copy link
Owner Author

@twop Indeed — hard coding the path to Rust's bundled one works for CI, but obviously not for local machines. I'll look into installing it in the CI!

@TheLostLambda TheLostLambda force-pushed the fix-macos-ci branch 3 times, most recently from 3c4f7dd to 870650d Compare November 8, 2024 16:08
@TheLostLambda
Copy link
Owner Author

@twop I think this is ready to go!

Let me know what you think of the solution and, importantly, if this fixes things on your local machine and closes #11

Thanks for pointing out that it was a doctest — that's why the linker settings weren't being respected!

@TheLostLambda TheLostLambda changed the title ci(macos): attempt to fix linker error ci(macos): fix linker error Nov 8, 2024
@TheLostLambda
Copy link
Owner Author

@twop Merging and closing #11

Let me know if that should be reopened, and I hope to look at your PR in the next couple of days!

@TheLostLambda TheLostLambda merged commit 163f329 into main Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants