Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| string = '' | ||
| i = 0 | ||
| while i < 100: | ||
| string += f'{random.randint(0,9)}' | ||
| i += 1 | ||
|
|
||
| string = ''.join(f'{random.randint(0, 9)}' for _ in range(100)) |
There was a problem hiding this comment.
Lines 4-9 refactored with the following changes:
- Use str.join() instead of for loop (
use-join) - Replace while with for (
while-to-for) - Replace unused for index with underscore (
for-index-underscore)
Comment on lines
17
to
23
| if i + 1 == target: | ||
| end_point = length # Catch any left-over bytes in the last segment. | ||
| else: | ||
| end_point = (i + 1) * seg_size | ||
| end_point = length if i + 1 == target else (i + 1) * seg_size | ||
| slice = bytes[start_point:end_point] | ||
| segments.append(slice) | ||
| i += 1 | ||
|
|
||
| checksums = [reduce(lambda acc, curr: acc ^ curr, segment) for segment in segments] | ||
|
|
||
|
|
||
| return checksums No newline at end of file | ||
| return [reduce(lambda acc, curr: acc ^ curr, segment) for segment in segments] |
There was a problem hiding this comment.
Function compress refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# Catch any left-over bytes in the last segment.
Comment on lines
-11
to
+15
| for word in words: | ||
| styled_words.append(word.title()) | ||
| styled_words.extend(word.title() for word in words) | ||
| elif style == 'lowercase': | ||
| for word in words: | ||
| styled_words.append(word.lower()) | ||
| styled_words.extend(word.lower() for word in words) | ||
| elif style == 'uppercase': | ||
| for word in words: | ||
| styled_words.append(word.upper()) | ||
| styled_words.extend(word.upper() for word in words) |
There was a problem hiding this comment.
Function to_styled refactored with the following changes:
- Replace a for append loop with list extend [×3] (
for-append-to-extend)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!