Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions: Move an additional resource to assignment, and move an assignment item to additional resource #27515

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Mar 1, 2024

Because

In my opinion Josh Comeau's article about transforms is concise and clear, and very well explains transforms. I remember reading this article and it made so much sense to me. He also goes over some very useful tips and presents everything in a visual format. I think this article should be in the assignment section instead of additional resources

I've also moved the matrix article to the additional resources because I don't think it's important enough to be an assignment item

This PR

  • Move article on transitions from additional resources to assignment
  • Move article on matrix from assignment to additional resources

Issue

Closes #XXXXX

Additional Information

I honestly don't even see why matrix is mentioned at all in the lesson. In my opinion all mentions of it should be completely removed. I understand that it may be useful in some niche cases, and if TOP was a documentation website then it would be fine to keep it in for completeness.

But TOP should only present information that will actually be useful to learners. I haven't ever used the matrix function and I don't see myself using it. It's unnecessary overhead to have the learner have to learn about it. So what do you think if we removed it completely from the lesson and all mentions of it?

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Mar 1, 2024
@cakegod
Copy link
Contributor

cakegod commented Mar 1, 2024

Adding new resources and making other significant changes should be discussed first by opening an issue or discussion before creating a PR. Otherwise, you'll waste your time if your proposition is not accepted.

@nik-rev
Copy link
Contributor Author

nik-rev commented Mar 2, 2024

Adding new resources and making other significant changes should be discussed first by opening an issue or discussion before creating a PR. Otherwise, you'll waste your time if your proposition is not accepted.

Honestly I don't think this is a significant change, but for other PRs that I've done that I consider significant I do open issue, e.g. Overhaul installations section, New TDD exercises, Rename foundation lessons

thanks anyways though!

Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @nikitarevenco

@KevinMulhern KevinMulhern merged commit 53e842c into TheOdinProject:main Mar 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants