Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Git in the Real World lesson: fix wording to be in line with prior instruction #28635

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

MarkR-Dev
Copy link
Contributor

Because

The 3rd knowledge check question refers to performing a merge of a feature branch into main, but in the assignment subsection 'Ongoing Workflow' that the knowledge check links to (instruction 4), we are asked to perform a merge of main into a feature branch to check for merge conflicts. The wording of the knowledge check could be changed to avoid potential confusion.

This PR

  • Change sentence wording to reflect prior instruction in lesson.

Issue

None

Additional Information

None

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

The 3rd knowledge check question refers to performing a merge of a
feature branch into main, but in the assignment subsection 'Ongoing Workflow'
instruction 4, we are asked to perform a merge of main into a feature branch
to check for merge conflicts.
@github-actions github-actions bot added the Content: Git Involves Git content label Aug 14, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@MaoShizhong MaoShizhong merged commit 3b6b2ef into TheOdinProject:main Aug 15, 2024
3 checks passed
@MarkR-Dev MarkR-Dev deleted the fix-wording branch August 15, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Git Involves Git content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants