Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neon and Koyeb to list of PaaS options in Rails deployment lesson #29148

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

DrantDumani
Copy link
Member

Because

The Rails lesson on Deployment didn't list Koyeb and Neon as PaaS options, which are listed on the NodeJS version of the lesson

This PR

  • Lists Koyeb and Neon's info as PaaS options for users.

Issue

Closes #28862

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Dec 4, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these!

Just have a couple of requested changes. Since this is in the context of the Rails course, it doesn't make sense to point learners to the documentation around working with node/express.

ruby_on_rails/rails_basics/deployment.md Outdated Show resolved Hide resolved
ruby_on_rails/rails_basics/deployment.md Outdated Show resolved Hide resolved
@MaoShizhong
Copy link
Contributor

Perhaps should also close #28491?

@DrantDumani
Copy link
Member Author

My bad on just copy pasting from the node section. The links have been updated to the ruby on rails docs!

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshDevHub JoshDevHub merged commit 08d4513 into TheOdinProject:main Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment: "Our recommended PaaS services" should match the one in the NodeJS section
3 participants