Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Queries: Remove link to kevin powell's conquering responsive layout course #29299

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

GaneshS288
Copy link
Contributor

@GaneshS288 GaneshS288 commented Jan 9, 2025

Because

This lesson contained a resource that was already mentioned in a previous lesson.

This PR

Removed the link to Kevin Powell's Conquering Responsive Layouts course

Issue

Closes #29287

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

this resource was already mentioned in a previous lesson "Natural responsiveness".
repeating it is redundant.
@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Jan 9, 2025
@GaneshS288
Copy link
Contributor Author

GaneshS288 commented Jan 10, 2025

There were some errors in the lesson file that my markdownlint extension didn't highlight and the npm scripts were not working. Later when I got the npm scripts working I ran lint:lesson script and noticed the errors.

I ran the fix:lesson script and pushed another commit.

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR and thank you for fixing the lint issues 🚀

@JoshDevHub JoshDevHub merged commit 5c13f64 into TheOdinProject:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Queries: <Additional resources section links something already mentioned in a previous lesson>
2 participants