Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Messages: Add missing period to the body of commit message example #29312

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ruizterce
Copy link
Contributor

Added a missing period to the body of the good commit message example to adhere to punctuation conventions and emphasize the difference between the subject and the body.

Because

The current example in the lesson about writing good commit messages lacks proper punctuation in the body of the commit message. This can lead to confusion for learners about the conventions of writing commit messages, as it doesn’t illustrate the best practice of punctuating the body properly. Adding the missing period helps clarify the difference between the subject and the body and ensures the example adheres to punctuation conventions.

This PR

  • Adds a missing period to the body of the commit message example in the lesson.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added a missing period to the body of the good commit message example to adhere to punctuation conventions and emphasize the difference between the subject and the body.
@github-actions github-actions bot added the Content: Git Involves Git content label Jan 12, 2025
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change 🚀

@JoshDevHub JoshDevHub merged commit f591c51 into TheOdinProject:main Jan 13, 2025
3 checks passed
@ruizterce ruizterce deleted the patch-1 branch January 13, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Git Involves Git content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants