Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project_basic_informational_site.md #29319

Closed
wants to merge 1 commit into from

Conversation

standiki
Copy link

@standiki standiki commented Jan 14, 2025

Under the instructions of the Project: Basic Informational Site assignment, on instruction two (2), the bulleted-list hints, I propose that the file extension should be added to the hints to provide a clearer meaning to readers. With the way it's right now, readers are being instructed to access the file pathname which does not exist. With my server running I tried to access the links or pages as described in the assignment instructions, it's the 404.html page that is always returned. The pages are served correctly when I add the .html extension to the file name. Rather than this:

It should be this way:

Because

This PR

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Under the instructions of the Project: Basic Informational Site assignment, on instruction two (2), the bulleted-list hints, I propose that the file extension should be added to the hints to provide a clearer meaning to readers. With the way it's right now, readers are being instructed to access the file pathname which does not exist. With my server running I tried to access the links or pages as described in the assignment instructions, it's the 404.html page that is always returned. The pages are served correctly when I add the `.html` extension to the file name. Rather than this:

- [localhost:8080](http://localhost:8080/) should take users to index.html
- [localhost:8080/about](http://localhost:8080/about) should take users to about.html
- [localhost:8080/contact-me](http://localhost:8080/contact-me) should take users to contact-me.html
- 404.html should display any time the user tries to go to a page not listed above.

It should be this way:

- [localhost:8080](http://localhost:8080/) should take users to index.html
- [localhost:8080/about.html](http://localhost:8080/about.html) should take users to about.html
- [localhost:8080/contact-me.html](http://localhost:8080/contact-me.html) should take users to contact-me.html
- 404.html should display any time the user tries to go to a page not listed above.
@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Jan 14, 2025
@standiki
Copy link
Author

standiki commented Jan 14, 2025

For further information regarding this PR leave a comment and I'll respond immediately. Thank you.

@standiki standiki closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant