CONTRIBUTING.md: Amend linting note about npm script file path #29323
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Currently, the linting guide has a note about running the
npm run lint/fix:*
scripts in the repo root else it won't find the correct config files. This is technically incorrect (which is my own mistake!) because npm scripts always run from the package root. Linting issues when users' terminals are in a subdirectory actually come from the file path, which they're often writing relative to their terminal location and not the package root, and has nothing to do with their current terminal location.i.e. they can be inside
./javascript/testing_javascript
and as long as they run with a path relative to root, they'll be fine e.g.npm run lint:lesson -- ./javascript/testing_javascript/test_basics.md
This PR
Issue
N/A
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section