fix unsigned vs signed issues in D2DamageStrc #147
Conversation
…ever dwDmgTotal is currently unsigned in the D2DamageStrc struct
source/D2Game/src/UNIT/SUnitDmg.cpp
Outdated
| @@ -1290,7 +1290,7 @@ void __fastcall SUNITDMG_ExecuteEvents(D2GameStrc* pGame, D2UnitStrc* pAttacker, | |||
| STATLIST_SetUnitStat(pDefender, STAT_HITPOINTS, nNewHp, 0); | |||
| } | |||
|
|
|||
| if (pDamage->dwDmgTotal > 0) | |||
There was a problem hiding this comment.
I think we should change dwDmgTotal to be signed instead of fixing it only here.
For example it appears in D2Game.0x6FD049D0 too, and it also checks for negative values.
…eStrct since this is how they are treated in d2game
True. I looked at the D2DamageStrc and found several unsigned values that should be signed. This pr is now about signed vs unsigned in D2DamageStrc. |
nooperation
changed the title
I think it would be fine to put it as signed since it's passed to |
Updated |
the original codebase has dwDmgTotal being treated as a signed value (jle) on this comparison. This causes differences to the original client when dwDmgTotal is negative