Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wordlist symlinks, fzf-rules aliase and hashcat rules #394

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

Tednoob17
Copy link

I added any function in packages_wordlists who add rules for hashcat, i implement fzf-rules aliase and create symlinks of directory contained a wordlists in /opt/lists .

Copy link
Member

@ShutdownRepo ShutdownRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR! small changes and we should be good to go

sources/assets/shells/aliases.d/fzf Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
@ShutdownRepo ShutdownRepo added waiting for additional changes new tool(s) This adds one or multiple tools to Exegol labels Oct 10, 2024
@qu35t-code
Copy link
Member

Hey @Tednoob17,

Can you be compliant with folder path ?
Sometimes they end with a slash, sometimes not.

@qu35t-code qu35t-code self-assigned this Oct 18, 2024
@Tednoob17
Copy link
Author

No problem, give me 5 minutes.

@Tednoob17
Copy link
Author

Only last commit can be considered

sources/install/package_forensic.sh Outdated Show resolved Hide resolved
sources/install/package_forensic.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
@qu35t-code
Copy link
Member

@ShutdownRepo, maybe we can move /opt/seclists into /opt/lists ?

@qu35t-code qu35t-code added waiting for review and removed waiting for additional changes new tool(s) This adds one or multiple tools to Exegol labels Oct 20, 2024
@qu35t-code qu35t-code added the enhancement New feature or request label Oct 20, 2024
sources/install/package_wordlists.sh Outdated Show resolved Hide resolved
Copy link
Member

@qu35t-code qu35t-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ShutdownRepo ShutdownRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some changes following @qu35t-code's review and comments
Also do you mind changing the seclist install from git -C /opt clone --single-branch --branch master --depth 1 https://github.com/danielmiessler/SecLists.git seclists to git -C /opt/lists clone --single-branch --branch master --depth 1 https://github.com/danielmiessler/SecLists.git seclists

Sorry for all those change requests, I didn't think the PR would question so many previous things 😅 but it's a good thing I guess

add-to-list "onelistforall,https://github.com/six2dez/OneListForAll,Rockyou for web fuzzing"
}

function install_rules(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want to unzip the files here for two reasons

  1. it gets a bit heavy (72M)
  2. hashcat already support on-the-fly loading of compressed wordlists (https://github.com/hashcat/hashcat/blob/ba2746228a40ebeed53a187dfa54fc6154234481/docs/changes.txt#L14), I guess it works with rules as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, i remove all gunzip, but with add-test-command i keep it for checking zip files? @ShutdownRepo

@@ -1,4 +1,5 @@
alias fzf-wordlists='find /opt/rockyou.txt /opt/seclists /usr/share/wordlists /usr/share/wfuzz /usr/share/dirb -type f | fzf'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/opt/seclists can be removed here since seclists will be in /opt/lists (@qu35t-code was right, it's a good idea)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i remove /opt/rockyou.txt because now rockyou.txt is in /opt/lists/rockyou.txt and since i already added /opt/lists /opt/rockyou.txt is no longer relevant

Comment on lines 49 to 51
mkdir -p /usr/share/wordlists
ln -v -s /opt/seclists /usr/share/seclists
ln -v -s /opt/seclists /usr/share/wordlists/seclists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be removed, I don't even know why they were created in the first place to be honest

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here i modify the following lines :
47 cd /opt/seclists || exit
by
cd /opt/lists/seclists || exit

And
50 add-test-command "[[ -f '/usr/share/wordlists/rockyou.txt' ]]"
51 add-test-command "[[ -d '/opt/seclists/Discovery/' ]]"
by
add-test-command "[[ -f '/opt/lists/rockyou.txt' ]]"
add-test-command "[[ -d '/opt/lists/seclists/Discovery/' ]]"

@qu35t-code
Copy link
Member

@Tednoob17,

Can you add wordlists from assetnote ? https://wordlists.assetnote.io/

@Tednoob17
Copy link
Author

Hi @qu35t-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for fix Waiting for the fix to be added on exegol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants