Don't trigger hide animation on load + force reflow to avoid chrome b…

…ug. Thanks to Sebastian Pettersson
TheRusskiy · Dec 21, 2014 · fd71f1d · fd71f1d
1 parent 0899029
commit fd71f1d
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 8 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "ng-slide-down",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "authors": [
     "TheRusskiy <[email protected]>"
   ],

diff --git a/demo/ng-slide-down.js b/demo/ng-slide-down.js
@@ -86,7 +86,10 @@
           if (value) {
             return $timeout(show);
           } else {
-            element.css({ height: getHeight() });
+            if (value != null) {
+              element.css({ height: getHeight() });
+              element[0].clientHeight;
+            }
             return $timeout(hide);
           }
         });

diff --git a/dist/ng-slide-down.js b/dist/ng-slide-down.js
@@ -86,7 +86,10 @@
           if (value) {
             return $timeout(show);
           } else {
-            element.css({ height: getHeight() });
+            if (value != null) {
+              element.css({ height: getHeight() });
+              element[0].clientHeight;
+            }
             return $timeout(hide);
           }
         });

diff --git a/dist/ng-slide-down.min.js b/dist/ng-slide-down.min.js
diff --git a/src/ng-slide-down.coffee b/src/ng-slide-down.coffee
@@ -63,9 +63,11 @@ angular.module("ng-slide-down", []).directive "ngSlideDown", ($timeout )->
       if value
         $timeout show
       else
-        element.css {
-          height: getHeight()
-        }
+        if value?
+          element.css {
+            height: getHeight()
+          }
+          element[0].clientHeight # Force reflow so the animation triggers reliably
         $timeout hide
 
   return {