-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game Over screen Bug fix #158 #168
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a few nits, great catch
((setup_player, despawn_dead_player) | ||
(( | ||
setup_player, | ||
despawn_dead_player.after(super::game_over::on_game_over), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be cleaner to use a SystemSet
for ordering this but not really necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the pub(crate)
changes necessary here?
@@ -21,7 +21,7 @@ pub struct GentPhysicsBundle { | |||
pub linear_velocity: LinearVelocity, | |||
} | |||
|
|||
#[derive(Component)] | |||
#[derive(Component, Debug)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this derive needed or was it just used to debug the issue?
Fixes by requiring despawn to happen after the gameover screen is spawned in.