Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game Over screen Bug fix #158 #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

opfromthestart
Copy link

Fixes by requiring despawn to happen after the gameover screen is spawned in.

@opfromthestart opfromthestart linked an issue Jan 11, 2025 that may be closed by this pull request
Copy link
Contributor

@mnmaita mnmaita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a few nits, great catch

((setup_player, despawn_dead_player)
((
setup_player,
despawn_dead_player.after(super::game_over::on_game_over),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be cleaner to use a SystemSet for ordering this but not really necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the pub(crate) changes necessary here?

@@ -21,7 +21,7 @@ pub struct GentPhysicsBundle {
pub linear_velocity: LinearVelocity,
}

#[derive(Component)]
#[derive(Component, Debug)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this derive needed or was it just used to debug the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game Over screen Bug fix [ $15 ]
2 participants