Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: load package definitions based on module name
Instead of relying solely on the file-path when loading a package, load from the module name instead. This should work for *most* external packages that are not installed into the ACA-Py folder. This should resolve the issue described in openwallet-foundation#2224 Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
- Loading branch information
bdadea6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to think of a way to optimize and minimize the change, but the reason why it works is because it's line 120 that throws an exception. I'll think on this a bit more
bdadea6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I think about it, depending on what module is for ACA-Py packages, we may be able to drop the file path method altogether. 🤔