Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rnpm & AndroidX for next release #1656

Closed
Shanie1331 opened this issue Jul 7, 2019 · 6 comments
Closed

rnpm & AndroidX for next release #1656

Shanie1331 opened this issue Jul 7, 2019 · 6 comments

Comments

@Shanie1331
Copy link

Requesting update for next releases.

The packages use deprecated "rnpm" config that will stop working from next release of React-native. Please give a release update for the same.
React-Native 6.0 have some breathtaking changes like:

  1. completely removing "rnpm" in next release.

Screen Shot 2019-07-08 at 12 48 56 AM

  1. AndroidX migration for mantained support lib version. All the support libs are updated to jetpack AndroidX. you can check these changes here.

These changes seems mandatory and I will be great if I can help you on same.

@CHaNGeTe
Copy link
Contributor

CHaNGeTe commented Jul 8, 2019

We are preparing for the upgrade:
#1656

But always, help is welcomed!

@CHaNGeTe CHaNGeTe closed this as completed Jul 8, 2019
@CHaNGeTe CHaNGeTe reopened this Jul 8, 2019
@CHaNGeTe
Copy link
Contributor

CHaNGeTe commented Jul 8, 2019

@Shanie1331 your feedback on that PR will be much appreciated. Specially about the rnpm part.

@kpratik2015
Copy link

kpratik2015 commented Jul 10, 2019

Add this to app/build.gradle and it might work

preBuild.doFirst { ant.replaceregexp(match:'android.support.v4.content.', replace:'androidx.core.content.', flags:'g', byline:true) { fileset(dir: '../../node_modules/react-native-video/android-exoplayer/src/main/java/com/brentvatne/exoplayer', includes: '*.java') } ant.replaceregexp(match:'android.support.annotation.', replace:'androidx.annotation.', flags:'g', byline:true) { fileset(dir: '../../node_modules/react-native-video/android-exoplayer/src/main/java/com/brentvatne/exoplayer', includes: '*.java') } }

@tslater
Copy link

tslater commented Jul 11, 2019

The above link is just linking to this issue. Here is the PR (as far as I can tell) for reference:
#1626

@CHaNGeTe
Copy link
Contributor

Sorry for that, yes, I meant this PR #1626

@benoitdion
Copy link
Collaborator

Closing this issue. #1626 has been merged and released in 5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants