Android ExoPlayer cache #1148
Android ExoPlayer cache #1148
Conversation
|
@RalfNieuwenhuizen What about cache size and max file size? |
|
@n1ru4l good point. I've added this to the list of TODO's. For max file size I haven't seen any issues yet while testing with https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4 |
|
@RalfNieuwenhuizen I actually wanted to write maximum allowed files to be in the cache 😅. |
|
I'd like to split the ExoPlayer update out into a separate PR. I would have done the upgrade sooner but ran into issues where it wanted to added an additional dependency on the support library or something like that. If you want to create a new PR for the upgrade, I can take care of getting the text track code updated. |
RalfNieuwenhuizen
force-pushed
the
android-exoplayer-caching
branch
from
b4f3a7d to
941ecc0
Compare
|
@cobarx ah, turns out the update isn't necessary at all, since I'm not using |
|
@RalfNieuwenhuizen I haven't looked into the details yet, but are you planning on supporting caching of HLS videos? |
|
@RalfNieuwenhuizen I wanted to give you a heads up that I merged the ExoPlayer 2.8.2 update (#1170) in case you want to use any of that stuff. I took care of the text track support. Edit: add PR link |
|
What are the blockers for this to be merged? Would love to get caching support for Android, too! |
|
@alizbazar It has a list of TODOs so I guess that's the reason |
|
Any word on this being completed? |
|
when will this be merged? need it very much |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you are having a similar problem, please open a new issue and reference this one instead of commenting on a stale or closed issue. |
* Return bytes read and written in export video method * Cleanup unused vars
…p#31) * Store exo player cache in subdirectory * Let exo player fully manage cache size * Restrict cache size to 380MB * Make cache evictor configurable * Make sub cache directory configurable * Use correct type
|
@hueniverse I have added some commits that help support a maximum cache size. That's all we have for now. Is this PR something you'd like to pick up? |
|
@RalfNieuwenhuizen Much appreciated! Can you explain the items left on the TODO list above? Would you be able to update the documentation for this feature? Is it on by default or only enabled if manually configured? |
Basic implementation of ExoPlayer cache.
What is does is load the media into a SimpleCache at the apps cache directory
"/video", which can be read by the ExoPlayer.The
exportVideomethod is meant for extracting a video file from the cache as an mp4 file, for example when you want to save it to the camera roll.In order to make this work I have updated ExoPlayer to 2.8.2 which included breaking changes for
setSelectedTextTrack.TODO's:
setSelectedTextTrack