get-packages #47
get-packages #47
Conversation
🦋 Changeset is good to goLatest commit: 6aa50cd We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tarang9211
changed the title
get-packages
packages/get-packages/package.json
Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "name": "get-packages", | |||
There was a problem hiding this comment.
| "name": "get-packages", | |
| "name": "@manypkg/get-packages", |
|
|
||
| const f = fixturez(__dirname); | ||
|
|
||
| describe("getPackages", () => { |
There was a problem hiding this comment.
It would be really good if we could deduplicate these tests, so adding tests to one would run for the other function as well.
This could use jest-in-case.
Can we do this for both these tests?
There was a problem hiding this comment.
I think this is done, right?
packages/get-packages/README.md
Outdated
| }; | ||
|
|
||
| export function getPackages(cwd: string): Promise<Packages>; | ||
| export function getPackagesSync(cwd: string): Packages; |
There was a problem hiding this comment.
This info seems not ideal as this is not a normal way of explaining imports.
This should really just be the import statements. Having the tool, package, and packages types is useful.
Speaking of, can we expose these as exports? Having access to types is nice.
There was a problem hiding this comment.
Do you want me to add exports to the types?
No description provided.