Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Proposal: ClientErrorLogService #211

Closed
jniles opened this issue Mar 24, 2016 · 1 comment
Closed

Design Proposal: ClientErrorLogService #211

jniles opened this issue Mar 24, 2016 · 1 comment
Labels
design

Comments

@jniles
Copy link
Collaborator

jniles commented Mar 24, 2016

This proposal partially addresses the issues #38 and #210 (imported from 1.X).

Motivation

Please see the referenced issues.

Design

This proposal is to create a new AngularJS service called ClientErrorLogService responsible for recording client errors in AppCache. The service will expose two methods:

  • log(type, error)
    • type (String) - the type of error logged (e.g. 'HTTP', '$routeChangeException', etc)
    • error (Object) - the exception object
  • clear()
    • This method will wipe the storage and all data inside with be cleared.

When the log() method is called, the service should store the following information:

  1. The current timestamp (new Date())
  2. The current url ($location.url())
  3. The current user (Session.user.username)
  4. The error type discussed above (type)
  5. The error stack trace (Error.stack)

All these should be properties should be stored as JSON in the AppCache, under the namespace ClientErrorLog. The number of records in AppCache should be limited to 1000 records. Once the 1000 records are exceeded, the oldest record is pop()ed off the end, and the newer record is added on. This is to prevent unlimited growth of the error log.

At this point, I am not convinced that we need an export() method, but it may be a good addition in the future.
@jniles jniles added the design label Mar 24, 2016
lomamech referenced this issue in lomamech/bhima-2.X Jan 30, 2017
@jniles
Merge pull request #211 from jniles/fix-account-management-submit-button
3e4055a 
fix(accounts): use loading button
@jniles jniles mentioned this issue Feb 12, 2017
Closed
@jniles
Copy link
Collaborator Author

jniles commented Jul 17, 2017

Closing this as out of scope at the moment.

@jniles jniles closed this as completed Jul 17, 2017
bors bot added a commit that referenced this issue Jun 27, 2018
@bors @greenkeeper
Merge #2946
df09167 
2946: Update mailgun-js to the latest version 🚀 r=jniles a=greenkeeper[bot]


## Version **0.19.0** of **[mailgun-js](https://github.com/bojand/mailgun-js)** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <code>[mailgun-js](https://github.com/bojand/mailgun-js)</code>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        0.18.1
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **0.19.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of mailgun-js.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Commits</summary>
<p>The new version differs by 4 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/8b78344104771204d655c12c77c89c6c182f4498"><code>8b78344</code></a> <code>0.19.0</code></li>
<li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/b880f5a7d90f34c06d8b99d4cee04266c8ef4d04"><code>b880f5a</code></a> <code>update deps. Fixes #210</code></li>
<li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/0463a155e79780b0f2dd8f2fc74f3e8a60392a7b"><code>0463a15</code></a> <code>Merge pull request #211 from aaronosher/patch-1</code></li>
<li><a href="https://urls.greenkeeper.io/bojand/mailgun-js/commit/0594ddd02cbf9dbe1981490441fed3acacf0a9bb"><code>0594ddd</code></a> <code>Update schema.js</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/bojand/mailgun-js/compare/373a858a33a96ce5dfb0bfa062bf5dd34d772786...8b78344104771204d655c12c77c89c6c182f4498">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit that referenced this issue Sep 18, 2019
@bors @greenkeeper
Merge #3892
be3367e 
3892: Update cross-env to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [cross-env](https://github.com/kentcdodds/cross-env) was updated from `5.2.1` to `6.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

**Publisher:** [kentcdodds](https://www.npmjs.com/~kentcdodds)
**License:** MIT

<details>
<summary>Release Notes for v6.0.0</summary>

<p><a name="user-content-6.0.0"></a></p>
<h1><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/v5.2.1...v6.0.0">6.0.0</a> (2019-09-17)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>bumped cross-spawn to version 7.0.0 (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/issues/211" data-hovercard-type="pull_request" data-hovercard-url="/kentcdodds/cross-env/pull/211/hovercard">#211</a>) (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf59">61ebf59</a>)</li>
</ul>
<h3>BREAKING CHANGES</h3>
<ul>
<li>Drop support for Node.js &lt; 7.</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 1 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf5970e88e915a09e80d0858ca6344efaa3ae"><code>61ebf59</code></a> <code>fix: bumped cross-spawn to version 7.0.0 (#211)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/a75fd0ef17b94f002166f894c357a1dee02cc97e...61ebf5970e88e915a09e80d0858ca6344efaa3ae">full diff</a></p>
</details>

---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit that referenced this issue Sep 18, 2019
@bors @greenkeeper
Merge #3892
733d7d6 
3892: Update cross-env to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [cross-env](https://github.com/kentcdodds/cross-env) was updated from `5.2.1` to `6.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

**Publisher:** [kentcdodds](https://www.npmjs.com/~kentcdodds)
**License:** MIT

<details>
<summary>Release Notes for v6.0.0</summary>

<p><a name="user-content-6.0.0"></a></p>
<h1><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/v5.2.1...v6.0.0">6.0.0</a> (2019-09-17)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>bumped cross-spawn to version 7.0.0 (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/issues/211" data-hovercard-type="pull_request" data-hovercard-url="/kentcdodds/cross-env/pull/211/hovercard">#211</a>) (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf59">61ebf59</a>)</li>
</ul>
<h3>BREAKING CHANGES</h3>
<ul>
<li>Drop support for Node.js &lt; 7.</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 1 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf5970e88e915a09e80d0858ca6344efaa3ae"><code>61ebf59</code></a> <code>fix: bumped cross-spawn to version 7.0.0 (#211)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/a75fd0ef17b94f002166f894c357a1dee02cc97e...61ebf5970e88e915a09e80d0858ca6344efaa3ae">full diff</a></p>
</details>

---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles