Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

PropTypes parsing no more works because RN now supports percents #19

Open
andrey-skl opened this issue Mar 22, 2017 · 0 comments
Open

Comments

@andrey-skl
Copy link

I have markup like this:

<div style="padding-left: 6px">
test
</div>

This fails to get parsed into styles {paddingLeft: 6} and parses into {paddingLeft: '6px'} instead, because View's PropTypes now accept "string" for such properties, because they support "100%"-like styles now.

So this check not working anymore.
It still renders somehow on iOS, but on Android it causes such error:
Error while updating property 'paddingLeft' in shadow node of type: RCTView updateShadowNodeProp ViewManagersPropertyCache.java:111 setProperty ViewManagerPropertyUpdater.java:148 updateProps ViewManagerPropertyUpdater.java:52 updateProperties ReactShadowNode.java:264 createView UIImplementation.java:184 createView UIManagerModule.java:245 invoke Method.java:-2 invoke BaseJavaModule.java:345 invoke JavaModuleWrapper.java:136 run NativeRunnable.java:-2 handleCallback Handler.java:751 dispatchMessage Handler.java:95 dispatchMessage MessageQueueThreadHandler.java:31 loop Looper.java:154 run MessageQueueThreadImpl.java:196 run Thread.java:761

andrey-skl added a commit to andrey-skl/react-native-fence-html that referenced this issue Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant