Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star map star backend #210

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Star map star backend #210

merged 4 commits into from
Jan 26, 2022

Conversation

alexanderson1993
Copy link
Member

Description

Depends on #209 - Don't review until that is merged.

Adds the classes and inputs for creating, updating, and deleting stars. Also includes a simplified function which can turn the satellite properties of an object into cartesian (XYZ) coordinates.

Related Issue

Closes #174
Closes #175

How do you know the changes work correctly?

Added automated tests.

Types of changes

  • Docs Change (changes were only made to documentation)
  • Refactor (non-breaking change which improves code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the built-in project documentation.
  • My change adds dependencies to this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@tannerchamb tannerchamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! The tests pass fine and I don't see any issues.

@alexanderson1993 alexanderson1993 merged commit f875824 into develop Jan 26, 2022
@alexanderson1993 alexanderson1993 deleted the star-map-star-backend branch January 26, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants