Solar system backend #241
Merged
Solar system backend #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderson1993
commented
Mar 2, 2022
| if (params.atmosphericComposition) { | ||
| planet.isPlanet.atmosphericComposition = params.atmosphericComposition; | ||
| } | ||
| if (params.hasClouds) { |
There was a problem hiding this comment.
With any of these that could be the number 0, if the user passes 0 as the updated value, the if statements won't run. You should check to see if the property exists using the in operator, or you can check if the typeof is number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How do you know the changes work correctly?
Screenshots (if appropriate):
Types of changes
change)
Checklist: