Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship map movement systems #358

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Conversation

alexanderson1993
Copy link
Member

Description

Adds a PassengerMovement system and component to track the movement of an entity through a ship. This will apply to crew members and cargo containers, along with anything else that might move throughout a ship.

There were a few bugs in the implementation of other parts of the system that this pull request addresses.

Related Issue

Closes #265

How do you know the changes work correctly?

Added automated tests. It builds a ship map and a passenger, tells the passenger to move to different rooms, and tracks the movement to make sure its working properly.

Types of changes

  • Docs Change (changes were only made to documentation)
  • Refactor (non-breaking change which improves code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the built-in project documentation.
  • My change adds dependencies to this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexanderson1993 alexanderson1993 merged commit 557efa1 into develop Jun 23, 2022
@alexanderson1993 alexanderson1993 deleted the ship-map-movement-systems branch June 23, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant