Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include a button on the Navigation screen to make the view follow the ship's position #390

Merged
merged 3 commits into from
Aug 6, 2022

Conversation

alexanderson1993
Copy link
Member

Description

Creates a couple of hooks for tracking position, including one to cancel the tracking if the player manually pans the camera view.

Also adds the necessary data fetching functions for the navigation screen.

Related Issue

Closes #386

How do you know the changes work correctly?

Manual test:

  • Manually activate the random movement system by adding it to the list in /server/src/systems/index.ts
  • Start a flight
  • Go to the navigation screen
  • Click the "Follow Ship" button
  • The camera should now follow the ship as it randomly moves.

Types of changes

  • Docs Change (changes were only made to documentation)
  • Refactor (non-breaking change which improves code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the built-in project documentation.
  • My change adds dependencies to this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexanderson1993 alexanderson1993 merged commit 331bc0f into develop Aug 6, 2022
@alexanderson1993 alexanderson1993 deleted the navigation-follow-ship branch August 6, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Navigation Card - Include a button to immediately center the view on the player's ship
1 participant