-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first imp for dns reverse lookup name parsing and resolution #2
Merged
spendletonliveaction
merged 9 commits into
threateye
from
threateye-ndpi-hl-add-reverse-lookup-domain
Jul 14, 2022
+36
−0
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f2f4ece
first imp for dns reverse lookup name parsing and resolution
hl33ta b0bd666
indenting changes
hl33ta 781466b
indenting changes
hl33ta 142c32b
comments for clarity
hl33ta 2e8304c
fix potential buffer overflow case and ensure answer_domain is null t…
hl33ta bcb4f11
readability change
hl33ta 5f97d2e
parsing to properly handle the first dns answer domain name
hl33ta 2c30d1a
extend size of domain buffer to have enouh space for the largest of d…
hl33ta 836bc26
change if case to make sure reverse lookup parsing wont iterate past …
hl33ta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
indenting changes
commit 781466b296450ac809b440f9dedb790009f89771
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per RFC-1035, 3.1, it sounds like these groups are called labels, so this is likely a label length in octets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any other existing nDPI code elsewhere that extracts domain names? If so, it might be possible to follow those conventions or re-use existing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nDPI functions seem primarily to handle the query name so creating a similar function(s) for various answer types based on their format make sense here as we get more use cases for this parsing