Add InexistentExcelObjectException

Ticketpark · Oct 31, 2023 · 93a5ab2 · 93a5ab2
1 parent b8d58da
commit 93a5ab2
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 4 deletions.
diff --git a/lib/HtmlPhpExcel/Exception/InexistentExcelObjectException.php b/lib/HtmlPhpExcel/Exception/InexistentExcelObjectException.php
@@ -0,0 +1,9 @@
+<?php
+declare(strict_types=1);
+
+namespace Ticketpark\HtmlPhpExcel\Exception;
+
+class InexistentExcelObjectException extends Exception
+{
+
+}
diff --git a/lib/HtmlPhpExcel/HtmlPhpExcel.php b/lib/HtmlPhpExcel/HtmlPhpExcel.php
@@ -4,7 +4,7 @@
 
 use avadim\FastExcelWriter\Excel;
 use Ticketpark\HtmlPhpExcel\Elements as HtmlPhpExcelElement;
-use Ticketpark\HtmlPhpExcel\Exception\HtmlPhpExcelException;
+use Ticketpark\HtmlPhpExcel\Exception\InexistentExcelObjectException;
 use Ticketpark\HtmlPhpExcel\Parser\Parser;
 
 class HtmlPhpExcel
@@ -103,18 +103,22 @@ public function process(?Excel $excel = null): self
     public function download(string $filename): void
     {
         $filename = str_ireplace('.xlsx', '', $filename);
-        $this->excel->download($filename . '.xlsx');
+        $this->getExcelObject()->download($filename . '.xlsx');
     }
 
     public function save(string $filename): bool
     {
         $filename = str_ireplace('.xlsx', '', $filename);
 
-        return $this->excel->save($filename . '.xlsx');
+        return $this->getExcelObject()->save($filename . '.xlsx');
     }
 
     public function getExcelObject(): Excel
     {
+        if (null === $this->excel) {
+            throw new InexistentExcelObjectException('You must run process() before handling the excel object. ');
+        }
+
         return $this->excel;
     }
 

diff --git a/tests/HtmlPhpExcel/Tests/HtmlPhpExcelTest.php b/tests/HtmlPhpExcel/Tests/HtmlPhpExcelTest.php
@@ -4,6 +4,7 @@
 
 use avadim\FastExcelWriter\Excel;
 use PHPUnit\Framework\TestCase;
+use Ticketpark\HtmlPhpExcel\Exception\InexistentExcelObjectException;
 use Ticketpark\HtmlPhpExcel\HtmlPhpExcel;
 
 /**
@@ -47,6 +48,30 @@ public function testSave()
     public function testItReturnsExcelInstance()
     {
         $htmlphpexcel = new HtmlPhpExcel('<table></table>');
-        $this->assertInstanceOf(Excel::class, $htmlphpexcel->getExcelObject());
+        $this->assertInstanceOf(Excel::class, $htmlphpexcel->process()->getExcelObject());
+    }
+
+    public function testItThrowsExceptionIfProcessIsNotRunBeforeGettingExcelObject()
+    {
+        $this->expectException(InexistentExcelObjectException::class);
+
+        $htmlphpexcel = new HtmlPhpExcel('<table></table>');
+        $htmlphpexcel->getExcelObject();
+    }
+
+    public function testItThrowsExceptionIfProcessIsNotRunBeforeSave()
+    {
+        $this->expectException(InexistentExcelObjectException::class);
+
+        $htmlphpexcel = new HtmlPhpExcel('<table></table>');
+        $htmlphpexcel->save('foo');
+    }
+
+    public function testItThrowsExceptionIfProcessIsNotRunBeforeDownload()
+    {
+        $this->expectException(InexistentExcelObjectException::class);
+
+        $htmlphpexcel = new HtmlPhpExcel('<table></table>');
+        $htmlphpexcel->download('foo');
     }
 }