-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeMirror and Highlight.js: Add ability to define colors through Palette #5123
Conversation
Hi @BurningTreeC I like the idea of aligning the highlight.js and CodeMirror palettes with the currently selected core palette. However, this implementation suffers from having to bloat all the core palettes with largely identical settings, increasing the friction significantly for anyone making a new palette, and making the palette editor even more unwieldy. Can we instead map the required plugin specific entries to existing core palette entries? I also have some concerns about the auto dark/mode work in #5085 which I'll comment there shortly. I wonder if we might need to rethink our approach to palettes/themes a little. |
Hi @Jermolene, I share your concerns and would also favor rethinking the palette-/theme approach. But we should postpone that to after the 5.1.23 release |
@BurningTreeC it might be worth making a ticket for this so we don't forget? |
@Jermolene, I've prepared a different PR adressing this, see #5128 |
This PR adds the
tiddlywiki
codemirror theme which defines the colors by the<<colour>>
macro. Like that we can define the codemirror colors through our palettesIt also makes the highlight.js plugin use the colors from the different palettes