-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer demo of alternate wiki store implementation #7329
Draft
Jermolene
wants to merge
76
commits into
master
Choose a base branch
from
demo-alternate-store
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 72 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
fdec12f
Initial commit
Jermolene 7fdd8a5
Merge branch 'master' into demo-alternate-store
Jermolene 6233710
Merge branch 'master' into demo-alternate-store
Jermolene b6bc197
Remove unneeded override
Jermolene 3561318
Merge branch 'master' into demo-alternate-store
Jermolene 1d0b928
Incorporate @joshuafontany's plain JS wiki implementation
Jermolene 544e079
Proof of concept of instantiating sqlite3 without needing external de…
Jermolene 0546a14
Restructure the sqlite3 store as a separate plugin
Jermolene 146a22b
Make rawmarkup code dynamically load dependencies
Jermolene 449e227
Test code to exercise the database
Jermolene 6f24f33
Include sqlite3 in the empty edition
Jermolene c43bc8f
Start prototyping some tiddler operations in sql
Jermolene 831fb39
Tiddler sql function tests should show custom field
Jermolene 8690936
Cleanup and clarify
Jermolene 9427cf7
Additional method to retrieve all titles
Jermolene 9ac21f1
Simplify the plain JS store implementation
Jermolene 7e60726
Wire the sql functions into the wiki object
Jermolene 9cb8721
Use sql functions for processing shadow tiddlers
Jermolene ede5f1e
Prepare the save tiddler query
Jermolene 8399538
Merge branch 'master' into demo-alternate-store
Jermolene 2099c4f
Turn on performance instrumentation for testing
Jermolene 12a19bb
Remove instrumentation
Jermolene 87213f2
Refactpr sql-wiki-store into two files
Jermolene 6ded5e6
Merge branch 'master' into demo-alternate-store
Jermolene b29af44
Fix typo
Jermolene 1f4be3e
I experimented with custom collations to match JS sort order, but 5x …
Jermolene 687b1df
Merge branch 'master' into demo-alternate-store
Jermolene 71c02e5
Merge branch 'master' into demo-alternate-store
Jermolene 2d229e2
Add logging utility
Jermolene 9e190a4
Use a temporary database so that multiple wiki stores can coexist
Jermolene 21ef2d7
Make the tests work in the browser
Jermolene f3bc32a
Merge branch 'master' into demo-alternate-store
Jermolene d2e21dd
Add a custom collator that matches JS ordering
Jermolene 64ffa52
Write tiddlers with string fields
Jermolene b557dea
Update comment
Jermolene e3255a4
Merge branch 'master' into demo-alternate-store
Jermolene f48bddb
Merge branch 'master' into demo-alternate-store
Jermolene 709669b
Merge branch 'master' into demo-alternate-store
Jermolene cc2cd20
Add tags tables and tag indexer and make custom collator be optional
Jermolene 83e7d32
Merge branch 'master' into demo-alternate-store
Jermolene 979a1f7
Introduce sql console
Jermolene 88c8c2c
SQL console - process query on enter key
Jermolene b4fe896
Styling for SQL console
Jermolene 09b0e28
Style update for sql console
Jermolene 2cd2a05
Fix tag saving
Jermolene 2d3027f
Sql console styling
Jermolene 7fd2dd5
Wire up the tag indexer properly
Jermolene b9245da
Sort tag lookups according to TW semantics
Jermolene 39d0451
Experiment with optimising specific filters with direct SQL equivalents
Jermolene 7eeaa20
Merge branch 'master' into demo-alternate-store
Jermolene bb41ae0
Merge branch 'master' into demo-alternate-store
Jermolene e6309e9
Fix tag collation syntax
Jermolene 66cba18
Merge branch 'master' into demo-alternate-store
Jermolene 25138ec
Merge branch 'master' into demo-alternate-store
Jermolene 1754be2
Merge branch 'master' into demo-alternate-store
Jermolene c52014c
Simplify the SQL schema
Jermolene fd3d8ae
Merge branch 'master' into demo-alternate-store
Jermolene 863066d
Merge branch 'master' into demo-alternate-store
Jermolene d4dec0c
Use the empty string as special plugin name for ordinary tiddlers
Jermolene f49b9fa
Move tags into their own tables
Jermolene 12c6cb3
Add indexes for columns used in joins
Jermolene dc94ed8
Refactor indexer implementation
Jermolene 3a4f5b8
Cache allTitles and allShadowTitles
Jermolene e9d640b
Fix sqlAllTitles wrongly including shadow tiddlers
Jermolene 01e1882
More indexes
Jermolene a58f119
Enable performance instrumentation
Jermolene e4af21a
Don't use LEFT JOIN unless we have to
Jermolene d982658
Remove all plugins to simplify benchmarking
Jermolene 8c1f7a6
SQL Console: Add number of rows returned
Jermolene 9493084
Merge branch 'master' into demo-alternate-store
Jermolene 02f3065
Revert attempt at optimising filter execution
Jermolene d7f0c5c
Minor refactoring
Jermolene 6997c61
Refactor filter compilation to allow SQL engine to optimise queries
Jermolene 5d20e98
Refactor filter compilation into its own source file
Jermolene 4897248
Fix indentation
Jermolene 6983564
Merge branch 'master' into demo-alternate-store
Jermolene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
title: $:/config/Performance/Instrumentation | ||
text: no | ||
text: yes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{ | ||
"description": "Empty edition", | ||
"plugins": [ | ||
"tiddlywiki/sqlite3store" | ||
], | ||
"themes": [ | ||
"tiddlywiki/vanilla", | ||
|
2 changes: 2 additions & 0 deletions
2
editions/prerelease/tiddlers/system/configPerformanceInstrumentation.tid
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
title: $:/config/Performance/Instrumentation | ||
text: yes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
editions/tw5.com/tiddlers/system/configPerformanceInstrumentation.tid
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
title: $:/config/Performance/Instrumentation | ||
text: yes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"title": "$:/plugins/tiddlywiki/demo-alternate-store", | ||
"name": "Demo alternate store", | ||
"description": "Developer demo of an alternate wiki store implementation", | ||
"list": "readme" | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the indent-level here is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmario fixed in 4897248