Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a workflow that runs when a CLA signature is merged #8375

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

saqimtiaz
Copy link
Member

This PR creates a workflow that runs when PRs modify the licenses/cla-individual.md file, and contains two jobs:

  1. When a PR is opened, it checks that the PR targets the tiddlywiki-com branch and if not adds the following comment on the PR: @$AUTHOR Signatures to the CLA must target the 'tiddlywiki-com' branch.

  2. When a PR is merged, it checks to see if there are any other open PRs by the other of the merged PR, and for each of them adds the following comment: **$AUTHOR** has signed the Contributor License Agreement (see [contributing.md](https://github.com/Jermolene/TiddlyWiki5/blob/master/contributing.md))

Fixes #7813

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Jul 13, 2024 11:54am

Copy link

saqimtiaz has signed the Contributor License Agreement (see contributing.md)

@Jermolene
Copy link
Member

Terrific thank you @saqimtiaz.

Very minor point, but I wondered if can we change the icon and/or name displayed with the PR comment?

image

@Jermolene Jermolene merged commit da697f1 into TiddlyWiki:master Jul 13, 2024
5 checks passed
@saqimtiaz
Copy link
Member Author

Very minor point, but I wondered if can we change the icon and/or name displayed with the PR comment?

As far as I am aware, that would only be possible if we posted the comments as another GitHub account with write access to the repository using a personal access token. A TiddlyWiki GitHub bot account for instance. Alternatively a GitHub app that we created and authorized to have access to the repository might also work.

tsukasa-au pushed a commit to tsukasa-au/TiddlyWiki5 that referenced this pull request Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate checking that PR authors have signed the Contributor License Agreement
2 participants