-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the testcase widget for the $reveal widget examples #8406
Use the testcase widget for the $reveal widget examples #8406
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @btheado – sorry if I'm missing something obvious, but why can't these examples use separate testcase compound tiddlers? |
I was thinking the testcase compound tiddlers required the expected results which don't seem to mean much for interactive examples. It would only show that the initial rendering is correct, but not actually verify the intended interactive behavior. Maybe I need to check this assumption. Compare to this pending PR where I do use testcase tiddlers: #8376 |
Hi @btheado if the "ExpectedResults" tiddler is omitted then the testcase widget will not perform the test result checks. However, we might need to check in case the jasmine runner objects |
OK, thanks. I'll play around with these examples as testcase tiddlers and see what happens. |
Ok, I misremembered. It wasn't that the Expected Results were required is was that the view template didn't activate unless one of the If you prefer to use the I didn't check yet how the jasmine runner behaves, but worst case, such tiddlers don't need to go into the tiddlers/testcases subdirectory. That way jasmine won't even see them. |
These examples are intended to be interactive and the expect results only test the initial rendering. Still that seems like useful verification
I converted to testcase tiddlers. The jasmine runner treated the tests without ExpectedResult as passing tests and it worked fine. However, I figured it wouldn't hurt to add ExpectedResult of at least the initial rendering and so I did. |
One point of friction with test case tiddlers is that editing via node.js causes the I suppose that is due to (from Customising Tiddler File Naming):
I haven't yet figured out how to change that for |
It worked to create a tiddler
|
Thank you @btheado I think that would be worth another PR to explore solutions for this. We can't ship |
) * Use the testcase widget for the $reveal widget examples * Convert $reveal testcase widget examples into testcase tiddlers * Add expected results to $reveal test case tiddlers These examples are intended to be interactive and the expect results only test the initial rendering. Still that seems like useful verification
Translate the
$reveal
examples to use the$testcase
widget.Directly used the
$testcase
widget rather than test case tiddlers so the user can interactively click the buttons to see the behavior.