Remove function wrapper #8625
Merged
Remove function wrapper #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
Jermolene
reviewed
Sep 30, 2024
|
IMO it's better to start with other plugins like Browser Storage and wrapper.js in markdown plugin, which can be easier to see the effect of the change. |
|
I think that's right @Leilei332. I actually do use the aws plugin but I wouldn't be surprised if it is not at all widely used. |
|
But I needed to start somewhere and for ease of management I started alphabetically. |
|
Apologies for the confusion @pmario please go ahead and make the modification I requested and then we can merge this. |
|
@Jermolene -- I did add the anonymous function wrapper back to sjcl.tid |
|
Thanks @pmario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove function wrapper for the aws-pluin
Important -- @Jermolene -- I can not test this one. So you will have to have a closer look.