Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tilde and updated dependencies #7

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Conversation

kdpsingh
Copy link
Member

@kdpsingh kdpsingh commented Aug 6, 2023

No description provided.

@kdpsingh
Copy link
Member Author

kdpsingh commented Aug 6, 2023

The code works when run interactively but the issue is that the docs don’t build correctly without the tilde prefixed to functions because of the way the __init__() function is currently written, which makes an assumption about the environment in which TidierData is loaded. We won’t merge this until the docs build correctly.

Once we get this to work, will also need to document this somewhere because other users who rely on TidierData and TidierCats in their own packages may run into a similar issue.

@kdpsingh kdpsingh marked this pull request as draft August 6, 2023 14:17
@kdpsingh
Copy link
Member Author

kdpsingh commented Aug 6, 2023

Possibly may need to export TidierData.not_vectorized[] for this code to work within the doctests.

@kdpsingh
Copy link
Member Author

kdpsingh commented Aug 6, 2023

I've never met a more untidy cat than this PR.

@kdpsingh
Copy link
Member Author

kdpsingh commented Aug 7, 2023

It looks like the reason the earlier builds were failing were because an older version of TidierData (v0.8.0) was cached during the documentation build, and so the not_vectorized[] list wasn’t accessible. For now, we will leave the TidierCats.jl functions listed directly in the TidierData.jl package’s not_vectorized[] list. This will ensure that TidierCats.jl functions are not vectorized regardless of which order the packages are loaded.

@kdpsingh kdpsingh marked this pull request as ready for review August 7, 2023 03:55
@kdpsingh kdpsingh merged commit 0405447 into main Aug 7, 2023
@kdpsingh kdpsingh deleted the updated-docs-without-tilde branch August 7, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant