Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FFI generator for Windows #18

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Conversation

rfl890
Copy link
Contributor

@rfl890 rfl890 commented Oct 8, 2024

Uses RtlGenRandom API call to securely generate random data in a vanilla LuaJIT environment.

Tieske
Tieske previously approved these changes Oct 8, 2024
Copy link
Owner

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the code for generating a seed, this one should be tried

src/uuid/rng/init.lua Outdated Show resolved Hide resolved
@Tieske Tieske dismissed their stale review October 8, 2024 11:54

accidental approval

Copy link
Owner

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the code for generating a seed, this one should be tried

@rfl890 rfl890 requested a review from Tieske October 8, 2024 13:25
src/uuid/rng/init.lua Outdated Show resolved Hide resolved
src/uuid/rng/init.lua Outdated Show resolved Hide resolved
src/uuid/rng/init.lua Outdated Show resolved Hide resolved
src/uuid/rng/init.lua Outdated Show resolved Hide resolved
@Tieske Tieske changed the title Add LuaJIT FFI generator for Windows Add FFI generator for Windows Oct 9, 2024
@Tieske Tieske merged commit 9cf7140 into Tieske:rewrite Oct 9, 2024
6 of 7 checks passed
Tieske pushed a commit that referenced this pull request Oct 9, 2024
Tieske pushed a commit that referenced this pull request Oct 9, 2024
Tieske pushed a commit that referenced this pull request Oct 9, 2024
Tieske pushed a commit that referenced this pull request Oct 9, 2024
@rfl890 rfl890 deleted the add-win-ffi-rng branch October 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants