-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the clang-format
pre-commit hook updated to the latest version
#2039
base: main
Are you sure you want to change the base?
Conversation
bfdba6d
to
3c4e5cf
Compare
84b42e2
to
10a8ebf
Compare
@kounelisagis @ihnorton can we perhaps have a discussion about syncing For those of us doing development on a single repo, whatever version the repo is using, the developer can easily switch to. For those of us doing multi-repo development -- and given that I'm aware of personally:
I'm all in favor of moving "into the future" -- just flagging the opportunity for a synchronize (unless there is such underway and I've missed it). |
10a8ebf
to
d0d9790
Compare
clang-format
pre-commit hook updated to the latest version
9c4326a
to
4edd287
Compare
Rebased onto the main branch |
Currently, clang-format runs only on linux in a non-standard way:
TileDB-Py/.github/workflows/format.yml
Lines 15 to 19 in d447f12
It should be better to use the pypi edition of it: https://pypi.org/project/clang-format/ which also provides pre-commit hook and it's system agnostic.
This PR:
.clang-format
file from TileDB-SOMA.clang-format
.actions/setup-python
instances to version 5.actions/checkout
instances to version 4.ruff
andblack
to their latest versions.[sc-43783]