Skip to content

Commit

Permalink
Dense reader: do not sort input ranges.
Browse files Browse the repository at this point in the history
Following up on #3002, it was
determined we should not sort the input ranges. If the user has a dense
vector of domain 1-10 and requests ranges 3-4 then 1-2, we should
return the ranges in that order.

---
TYPE: IMPROVEMENT
DESC: Dense reader: do not sort input ranges.

(cherry picked from commit 8aa752c)
  • Loading branch information
KiterLuc authored and ihnorton committed Apr 6, 2022
1 parent 3dfe242 commit 15271bf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
14 changes: 7 additions & 7 deletions test/src/unit-capi-dense_array.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5173,20 +5173,20 @@ TEST_CASE_METHOD(

// clang-format off
uint64_t c_a1_cm[] = {
503, 603, 1003, 1103, 1203, 1303, 1403, 1503, 1603,
504, 604, 1004, 1104, 1204, 1304, 1404, 1504, 1604
1003, 1103, 1203, 1303, 1403, 1503, 1603, 503, 603,
1004, 1104, 1204, 1304, 1404, 1504, 1604, 504, 604
};

uint64_t c_a1_rm[] = {
503, 504,
603, 604,
1003, 1004,
1103, 1104,
1203, 1204,
1303, 1304,
1403, 1404,
1503, 1504,
1603, 1604
1503, 1504,
1603, 1604,
503, 504,
603, 604
};
// clang-format on
if (layout == TILEDB_ROW_MAJOR) {
Expand All @@ -5196,4 +5196,4 @@ TEST_CASE_METHOD(
}

remove_temp_dir(temp_dir);
}
}
3 changes: 0 additions & 3 deletions tiledb/sm/query/dense_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -403,9 +403,6 @@ Status DenseReader::init_read_state() {
"subarrays do not "
"support global order"));

// Make sure ranges are sorted.
RETURN_NOT_OK(subarray_.sort_ranges(storage_manager_->compute_tp()));

// Get config values.
bool found = false;
uint64_t memory_budget = 0;
Expand Down

0 comments on commit 15271bf

Please sign in to comment.