Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The nightly GitHub Actions build job failed on Tuesday (2024-04-09) #4857

Closed
github-actions bot opened this issue Apr 9, 2024 · 3 comments · Fixed by #4859
Closed

The nightly GitHub Actions build job failed on Tuesday (2024-04-09) #4857

github-actions bot opened this issue Apr 9, 2024 · 3 comments · Fixed by #4859
Assignees
@davisp @teo-tsirpanis @KiterLuc
Labels
nightly

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

The nightly GitHub Actions build job failed on Tuesday (2024-04-09) in run 8609643464
@KiterLuc
Copy link
Contributor

KiterLuc commented Apr 9, 2024

@teo-tsirpanis some of the runners are hitting the webp issue here.

@teo-tsirpanis teo-tsirpanis mentioned this issue Apr 9, 2024
Closed
@teo-tsirpanis
Copy link
Member

I think I figured it out. It's not a problem with CMake per se, but an interaction between CMake and vcpkg.

CMake 3.29.1 changed the format of config files generated by the configure_package_config_file function, and vcpkg's vcpkg_cmake_config_fixup function was not updated to handle the new format, causing the failures.

Working on a fix.

@teo-tsirpanis teo-tsirpanis mentioned this issue Apr 9, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Apr 9, 2024

The nightly GitHub Actions build job failed on Tuesday (2024-04-09) in run 8615705659

@teo-tsirpanis teo-tsirpanis mentioned this issue Apr 9, 2024
Merged
@jdblischak jdblischak mentioned this issue Apr 9, 2024
Closed
KiterLuc pushed a commit that referenced this issue Apr 9, 2024
@teo-tsirpanis
Fix build errors with CMake 3.29.1. (#4859)
690479f 
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup`
command. This PR updates the port containing the command to adapt to the
new behavior. The change will be upstreamed with microsoft/vcpkg#38017.

Validated locally. For ease of review, the first commit copies the
existing port as-is, and the second commit updates it.

Fixes #4857
Fixes TileDB-Inc/TileDB-CSharp#405
Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83

---
TYPE: NO_HISTORY
github-actions bot pushed a commit that referenced this issue Apr 10, 2024
@teo-tsirpanis @github-actions
Fix build errors with CMake 3.29.1. (#4859)
c5c82d7 
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup`
command. This PR updates the port containing the command to adapt to the
new behavior. The change will be upstreamed with microsoft/vcpkg#38017.

Validated locally. For ease of review, the first commit copies the
existing port as-is, and the second commit updates it.

Fixes #4857
Fixes TileDB-Inc/TileDB-CSharp#405
Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83

---
TYPE: NO_HISTORY

(cherry picked from commit 690479f)
KiterLuc pushed a commit that referenced this issue Apr 10, 2024
@teo-tsirpanis @KiterLuc
Fix build errors with CMake 3.29.1. (#4859)
68fd5ff 
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup`
command. This PR updates the port containing the command to adapt to the
new behavior. The change will be upstreamed with microsoft/vcpkg#38017.

Validated locally. For ease of review, the first commit copies the
existing port as-is, and the second commit updates it.

Fixes #4857
Fixes TileDB-Inc/TileDB-CSharp#405
Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83

---
TYPE: NO_HISTORY

(cherry picked from commit 690479f)
teo-tsirpanis added a commit that referenced this issue Apr 10, 2024
@teo-tsirpanis
Fix build errors with CMake 3.29.1. (#4859)
897fd59 
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup`
command. This PR updates the port containing the command to adapt to the
new behavior. The change will be upstreamed with microsoft/vcpkg#38017.

Validated locally. For ease of review, the first commit copies the
existing port as-is, and the second commit updates it.

Fixes #4857
Fixes TileDB-Inc/TileDB-CSharp#405
Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83

---
TYPE: NO_HISTORY
dudoslav pushed a commit that referenced this issue Apr 17, 2024
@teo-tsirpanis @dudoslav
Fix build errors with CMake 3.29.1. (#4859)
25c90e7 
CMake 3.29.1 had a change that broke vcpkg's `vcpkg_cmake_config_fixup`
command. This PR updates the port containing the command to adapt to the
new behavior. The change will be upstreamed with microsoft/vcpkg#38017.

Validated locally. For ease of review, the first commit copies the
existing port as-is, and the second commit updates it.

Fixes #4857
Fixes TileDB-Inc/TileDB-CSharp#405
Fixes the root cause of TileDB-Inc/conda-forge-nightly-controller#83

---
TYPE: NO_HISTORY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davisp davisp

@teo-tsirpanis teo-tsirpanis

@KiterLuc KiterLuc

Labels
nightly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build errors with CMake 3.29.1. TileDB-Inc/TileDB
Pin CMake to 3.29.0. TileDB-Inc/TileDB
3 participants
@davisp @teo-tsirpanis @KiterLuc