Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version optional and remove 'latest' #59

Closed
wants to merge 1 commit into from

Conversation

leecrossley
Copy link

We want to be able to make the package name lamdba_thing.zip

@Tim-B
Copy link
Owner

Tim-B commented Jan 23, 2016

Hi Lee, thanks for the pull request!

My only concern is that by removing latest from the name it will change the naming convention for existing users who have include_time = false and don't have include_version set.

I made an option to have a static artifact name for users who have a deployment script or something that runs afterwards.

You can find an example use case of that here: https://aws.amazon.com/blogs/compute/continuous-integration-deployment-for-aws-lambda-functions-with-jenkins-and-grunt-part-2/

Set the Artifact Location to dist/create-thumbs-lambda_0-0-1_latest.zip as this is where Grunt generates the Lambda function bundle

Your pull request will help those users (seeing as the version name won't be dynamic), but I'd prefer the artifact name remained identical for existing users who don't have the include_version option set.

@Tim-B
Copy link
Owner

Tim-B commented Feb 15, 2016

An include_version option has been added in the latest version which should resolve this issue.

@Tim-B Tim-B closed this Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants