fixes build warning while supporting Flutter 2

TimeFinderApp · May 15, 2022 · c01651f · c01651f
1 parent 7c126c4
commit c01651f
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.2.1
+### Fixed
+* Build warning
+
 ## 1.2.0
 ### Added
 * A way to automatically close other Slidables within the same group by tapping on them.

diff --git a/example/ios/Runner.xcodeproj/project.pbxproj b/example/ios/Runner.xcodeproj/project.pbxproj
@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 46;
+	objectVersion = 50;
 	objects = {
 
 /* Begin PBXBuildFile section */
@@ -127,7 +127,7 @@
 		97C146E61CF9000F007C117D /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 1020;
+				LastUpgradeCheck = 1300;
 				ORGANIZATIONNAME = "";
 				TargetAttributes = {
 					97C146ED1CF9000F007C117D = {

diff --git a/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme b/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1020"
+   LastUpgradeVersion = "1300"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/example/ios/Runner/Info.plist b/example/ios/Runner/Info.plist
@@ -41,5 +41,7 @@
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
 	<false/>
+	<key>CADisableMinimumFrameDurationOnPhone</key>
+	<true/>
 </dict>
 </plist>
diff --git a/lib/src/auto_close_behavior.dart b/lib/src/auto_close_behavior.dart
@@ -388,7 +388,12 @@ class _SlidableAutoCloseBarrierNotificationSenderState
       // while the barrier was still enabled for this group.
       // We need to release the barrier.
 
-      SchedulerBinding.instance.addPostFrameCallback((Duration _) {
+      // In Flutter 3, [SchedulerBinding.instance] is not nullable, but since
+      // we want to support Flutter 2, this is a simple way to do it without
+      // having a build warning.
+      // ignore: unnecessary_nullable_for_final_variable_declarations
+      final SchedulerBinding? schedulerBinding = SchedulerBinding.instance;
+      schedulerBinding?.addPostFrameCallback((Duration _) {
         // We call it in the next frame to avoid to rebuild a widget that is
         // already rebuilding.
         dispatchSlidableAutoCloseBarrierNotification(enabled: false);

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: flutter_slidable
 description: A Flutter implementation of slidable list item with directional slide actions that can be dismissed.
-version: 1.2.0
+version: 1.2.1
 homepage: https://github.com/letsar/flutter_slidable
 
 environment: