-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance configuration (#12, #15) #20
enhance configuration (#12, #15) #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! I left some feedback about the way the configuration path is provided :)
I will take a deeper look on your improvements and ideas @TimonVS, i'm quite busy at the moment so it can take a few days. |
@amacado sure! Take your time :) |
Hey @amacado, I was wondering if you still wanted to apply the changes. If not, please let me know so that I can apply them myself so that we can get this PR merged :) |
Hey @TimonVS i was suffering a heavy cold the last two weeks and since it's my first day back in job I have a ton of work todo. If u have the time feel free to apply the changes, I would need at least a couple more weeks. |
Ah that's too bad about the cold :/, I hope you feel better soon! |
…rn default config on 404
I decided to separate #11 "Configure using the
with
parameter" from this pull request since it is more complex and requires some more changes. Will see when I got some time to work on #11