fix lint errors

TimothyYe · Apr 21, 2023 · d4d00f9 · d4d00f9
1 parent cc58c26
commit d4d00f9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/internal/provider/dreamhost/dreamhost_handler.go b/internal/provider/dreamhost/dreamhost_handler.go
@@ -47,11 +47,7 @@ func (provider *DNSProvider) updateIP(hostname, currentIP, lastIP string) error
 		return err
 	}
 
-	if err := provider.updateDNS(lastIP, currentIP, hostname, "add"); err != nil {
-		return err
-	}
-
-	return nil
+	return provider.updateDNS(lastIP, currentIP, hostname, "add")
 }
 
 // updateDNS can add or remove DNS records.

diff --git a/internal/utils/ip.go b/internal/utils/ip.go
@@ -143,10 +143,8 @@ func GetIPOnline(configuration *settings.Settings) (string, error) {
 		if onlineIP == "" {
 			log.Error(fmt.Sprintf("request:%v failed to get online IP", reqURL))
 			continue
-		} else {
-			log.Debugf("get ip success by: %s, online IP: %s", reqURL, onlineIP)
-			break
 		}
+		log.Debugf("get ip success by: %s, online IP: %s", reqURL, onlineIP)
 	}
 
 	if onlineIP == "" {

diff --git a/pkg/notification/email.go b/pkg/notification/email.go
@@ -38,10 +38,7 @@ func (n *EmailNotification) Send(domain, currentIP string) error {
 		n.conf.Notify.Mail.SMTPPassword)
 
 	// Send the email config by sendlist	.
-	if err := d.DialAndSend(m); err != nil {
-		return err
-	}
-	return nil
+	return d.DialAndSend(m)
 }
 
 var mailTemplate = `