Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submit tags BUG #9

Closed
wants to merge 1 commit into from
Closed

Fix submit tags BUG #9

wants to merge 1 commit into from

Conversation

Mattraks
Copy link
Contributor

@Mattraks Mattraks commented Dec 18, 2021 •
edited
Loading

I’m not sure what your "tags" function means,
I think it’s whether to sync tags.
When "tags" is not enabled, some tags will be synchronized

@Mattraks Mattraks closed this Dec 18, 2021
@Mattraks Mattraks reopened this Dec 18, 2021
@Mattraks Mattraks changed the title Update start.sh Fix submit tags BUG Dec 18, 2021
turbaszek
turbaszek reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mattraks can you explain what exactly is being fixed here?

@Mattraks
Copy link
Contributor Author

Mattraks commented Dec 22, 2021 •
edited
Loading

@Mattraks can you explain what exactly is being fixed here?

I’m not sure what your "tags" function means,
I think it’s whether to sync tags.
When "tags" is not enabled, some tags will be synchronized

@TobKed
Copy link
Owner

TobKed commented Dec 22, 2021

@Mattraks thank you very much for your contribution.
I see your point, now --follow-tags paramter is always implicitly used, despite of tags option.

I was thinking about changing the way of passing parameters to push by deprecating inputs like force and tags and adding more general argument like push_options where any of git push options could be passed. WDYT @Mattraks @turbaszek ?

@turbaszek turbaszek mentioned this pull request Feb 13, 2022
Closed
TobKed pushed a commit that referenced this pull request Feb 23, 2022
@Mattraks @TobKed
Fix submit tags BUG #9
f1df98d 
Resolved conflicts for PR:
#9

thanks Mattraks
https://github.com/Mattraks
@TobKed
Copy link
Owner

TobKed commented Feb 23, 2022

@Mattraks thanks you for contribution.
Based on your changes I made fix (f1df98d) since I couldn't do it directly in this PR.

@TobKed TobKed closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbaszek turbaszek turbaszek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mattraks @TobKed @turbaszek