Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain-name troubles. #3

Closed
svein83 opened this issue Jul 4, 2017 · 0 comments
Closed

Domain-name troubles. #3

svein83 opened this issue Jul 4, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@svein83
Copy link

svein83 commented Jul 4, 2017

It is assumed that all WebUntis servers have subdomains at webuntis.com (https://example.webuntis.com/WebUntis)

There are actors around the world which host WebUntis at other domains, and those servers can't be reached with this API as it is right now.

So it should be possible to enter a full domain-name, and not just names for those with subdomains at webuntis.com

A possible simple fix:
In /src/Webuntis.php, Line 63 the server name from the config-array is surrounded with https:// and .webuntis.com/WebUntis/jsonrpc.do?school='; in const PATH_SCHEME

If the ".webuntis.com"-part was stripped, then the full domain-name could be entered in the config-array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants