Use aliases and simplify installing php extensions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use
language: nonephp and composer are installed there anyway, so I think it's better to use travis php images, then we have clearer build lists - and then we are using just$TRAVIS_PHP_VERSION.We don't need
MONGO_DRIVERvariable in travis, as all should be configured in docker (we need some customization between different PHP versions).We don't need another
XDEBUGvariable in travis, we need xdebug only to generate coverage.We can use aliases, but these were not available by default, and we need to use:
shopt -s expand_aliases.Installation php modules could be simplified just to use
docker-php-ext-enable.