Async version of the TkinterMapView widget #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No thread involved. Everything is handled with async tasks.
Simple window inspired from original example. Simply replaced TkinterMapView with its async version.
Open
|
Nice work, only remark: You forgot to update the requirements. You are using aiohttp but it's not installed with the requirements.txt nor with the setup.py. |
Update both `requirements.txt` and `setup.py`
|
Oops, you're absolutely right. |
|
Nice, now hopefully this will be merged. But alas the project seems to be very dormant, seeing all the open pull requests here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the implementation for an async version of the
TkinterMapViewwidget (calledAsyncTkinterMapView).Why?
If willing to use this widget in an application that makes use of async tasks rather than threads, the original threaded version won't work. See issue #151.
How?
The implementation is basically a copy of the original class with every thread replaced by async actions. This is not pretty, but it works fine for basic usage. A basic example using this implementation is provided.