Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tries to reconnect to node when the node is deleted from nodeManager.nodes list #88

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

PandaIN95
Copy link
Contributor

Fix: clear unnecessary timers on nodeDelete.
Add: Before deleting any node now you Choose whether to move players to different node (lavalink.nodeManager.deleteNode() )

…emove timers on nodeDelete

Added: before deleting any node now you Choose whether to move players to different node.
Copy link

pkg-pr-new bot commented Jan 13, 2025

Open in Stackblitz

npm i https://pkg.pr.new/Tomato6966/lavalink-client@88

commit: ebced59

Copy link
Owner

@Tomato6966 Tomato6966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete my 4 comments

src/structures/Node.ts Outdated Show resolved Hide resolved
src/structures/NodeManager.ts Show resolved Hide resolved
src/structures/Node.ts Show resolved Hide resolved
src/structures/Node.ts Outdated Show resolved Hide resolved
@PandaIN95
Copy link
Contributor Author

@Tomato6966 Made changes you can check.

Copy link
Owner

@Tomato6966 Tomato6966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, will merge it and deploy as a patch locally

@Tomato6966 Tomato6966 merged commit 8803da4 into Tomato6966:main Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants