Clean up Ransack query for promotion code #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes up the ransack search when attempting to find Orders via a promotion code, by using one fewer join in the resulting query and going directly through the spree_orders_promotions table. This commit exists upstream as a WIP from @jhawthorn: solidusio@22ebde7
stewart
force-pushed
the
fix/promotion_code_ransack
branch
from
85264f8 to
93ad772
Compare
graygilmore
reviewed
Dec 8, 2016
| @@ -27,7 +27,7 @@ class CannotRebuildShipments < StandardError; end | |||
| go_to_state :confirm | |||
| end | |||
|
|
|||
| self.whitelisted_ransackable_associations = %w[shipments user promotions bill_address ship_address line_items] | |||
| self.whitelisted_ransackable_associations = %w[shipments user order_promotions promotions bill_address ship_address line_items] | |||
There was a problem hiding this comment.
Do we want to keep promotions here? I guess for the separate Promo page's search?
There was a problem hiding this comment.
The promotions association may still be useful in some contexts - I don't believe it's used in our application or in Solidus, but I'm hesitant to remove it unless it's also removed upstream first.
graygilmore
approved these changes
Dec 8, 2016
adammathys
approved these changes
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes up the ransack search when attempting to find Orders
via a promotion code, by using one fewer join in the resulting query and
going directly through the spree_orders_promotions table.
This commit exists upstream as solidusio#1662