Check and update Folder 2 for v24.3.0

[hrobarts]

No description provided.

[hrobarts]

In folder 2
01_optimisation_gd_fista

• objective function deprecation warning
• rtol and atol deprecation warning GD raises deprecation warning if atol and rtol are not used CIL#2054
• PDHG.py:406: UserWarning: Convergence criterion of PDHG for scalar step-sizes is not satisfied.
  warnings.warn(
• PDHG seems to be much slower? 40 minutes for 4500 iterations - notebook says it should take 5 minutes. Maybe this is a problem with the cloud machine I'm using
• PDHG dual gap is negative so doesn't show up on log plot

02_tikhonov_block_framework.ipynb

• show1D labels -> dataset_labels

03_PDHG

• show1D labels -> dataset_labels
• PDHG.py:406: UserWarning: Convergence criterion of PDHG for scalar step-sizes is not satisfied.
  warnings.warn(

[lauramurgatroyd]

1_optimisation
This cell should be code not markdown

opened: #235

[hrobarts]

04_SPDHG

• Same warning about change in behaviour for FGP_TV nonnegativity is now default False. Update to change nonnegativity=True?

This is with False

This is with True

• SPDHG explicit renormalising section is failing with a TypeError: unsupported operand type(s) for *=: 'NoneType' and 'float' @MargaretDuff , do you have any insight on what's going on here? It looks like it's failing on the first iteration

[hrobarts]

05_Laminography_with_TV no problems :)

[MargaretDuff]

04_SPDHG

• Same warning about change in behaviour for FGP_TV nonnegativity is now default False. Update to change nonnegativity=True?

This is with False This is with True

Yes, set nonnegativity=True

• SPDHG explicit renormalising section is failing with a TypeError: unsupported operand type(s) for *=: 'NoneType' and 'float' @MargaretDuff , do you have any insight on what's going on here? It looks like it's failing on the first iteration

This seems to be a bigger issue - let me have a look

[MargaretDuff]

I added a new issue in CIL: TomographicImaging/CIL#2058. I don't have a quick fix for this notebook though :(