Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V24.3.0 folder 2 updates #234

Merged
merged 13 commits into from
Feb 6, 2025
Merged

V24.3.0 folder 2 updates #234

merged 13 commits into from
Feb 6, 2025

Conversation

hrobarts
Copy link
Contributor

@hrobarts hrobarts commented Jan 30, 2025

01_optimisation_gd_fista

02_tikhonov_block_framework.ipynb

  • show1D labels -> dataset_labels

03_PDHG

  • show1D labels -> dataset_labels
  • Add check_convergence = False, in code and snippet

04_SPDHG

05_laminography_with_TV looks good!

closes #225

@hrobarts hrobarts self-assigned this Jan 30, 2025
@hrobarts hrobarts linked an issue Jan 31, 2025 that may be closed by this pull request
demos/2_Iterative/01_optimisation_gd_fista.ipynb Outdated Show resolved Hide resolved
demos/2_Iterative/02_tikhonov_block_framework.ipynb Outdated Show resolved Hide resolved
demos/2_Iterative/snippets/03_ex3.py Show resolved Hide resolved
demos/2_Iterative/03_PDHG.ipynb Show resolved Hide resolved
Copy link
Member

@MargaretDuff MargaretDuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 01 notebook looks good to me, I just left a few comments on the wording.

@hrobarts
Copy link
Contributor Author

hrobarts commented Feb 6, 2025

Thanks @MargaretDuff for looking at notebook 01. The other notebooks only have small changes so we're happy to merge.

@hrobarts hrobarts merged commit 515f9cc into main Feb 6, 2025
@hrobarts hrobarts deleted the v24.3.0_folder2 branch February 6, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants