Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

01_optimisation_gd_fista convergence plot doesn't show dual objective #233

Closed
hrobarts opened this issue Jan 30, 2025 · 0 comments · Fixed by #234
Closed

01_optimisation_gd_fista convergence plot doesn't show dual objective #233

hrobarts opened this issue Jan 30, 2025 · 0 comments · Fixed by #234

Comments

@hrobarts
Copy link
Contributor

When we plot the convergence of PDHG in the 01_optimisation_gd_fista notebook, the dual objective is still negative after 500 iterations so it doesn't show on the log plot, but does show in the legend which is potentially confusing:
Image

After 4500 iterations it becomes positive, so we see it on the graph and see the primal and dual objective are converging, but it's still a bit confusing that it appears out of nowhere:
Image

Perhaps we could plot the primal and dual objective separately on a non log plot so we can see them even if they're negative? Or maybe just add to the text to explain what's happening.

@hrobarts hrobarts linked a pull request Jan 31, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant