You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we plot the convergence of PDHG in the 01_optimisation_gd_fista notebook, the dual objective is still negative after 500 iterations so it doesn't show on the log plot, but does show in the legend which is potentially confusing:
After 4500 iterations it becomes positive, so we see it on the graph and see the primal and dual objective are converging, but it's still a bit confusing that it appears out of nowhere:
Perhaps we could plot the primal and dual objective separately on a non log plot so we can see them even if they're negative? Or maybe just add to the text to explain what's happening.
The text was updated successfully, but these errors were encountered:
When we plot the convergence of PDHG in the 01_optimisation_gd_fista notebook, the dual objective is still negative after 500 iterations so it doesn't show on the log plot, but does show in the legend which is potentially confusing:
![Image](https://private-user-images.githubusercontent.com/77114597/408227955-b8c4b5e6-2439-4f87-bc91-9392c9845daf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODIyNzYsIm5iZiI6MTczOTQ4MTk3NiwicGF0aCI6Ii83NzExNDU5Ny80MDgyMjc5NTUtYjhjNGI1ZTYtMjQzOS00Zjg3LWJjOTEtOTM5MmM5ODQ1ZGFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDIxMjYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlYjg4ODM3N2U1NGM5MmE4MmE2OTZlZmI2ZDBlMzBiNWNkNDcwODNmMDdlMDg2ZjAzOGU3MDU0NTYyNzQzNzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.T5b1o1tzezE9bHJfCsKEZwPCngv1TqEmCVD05tgW9tY)
After 4500 iterations it becomes positive, so we see it on the graph and see the primal and dual objective are converging, but it's still a bit confusing that it appears out of nowhere:
![Image](https://private-user-images.githubusercontent.com/77114597/408228098-87de57e0-b4a1-4661-a60e-36cc6f4e1620.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODIyNzYsIm5iZiI6MTczOTQ4MTk3NiwicGF0aCI6Ii83NzExNDU5Ny80MDgyMjgwOTgtODdkZTU3ZTAtYjRhMS00NjYxLWE2MGUtMzZjYzZmNGUxNjIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDIxMjYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZlNzYzNmIzMDczNzdiNWJmM2EwZTk2ZjNhYjM4ZTFjYTNhMjJmMzJjZWU1ODY1ZDQ1ZjAwNDMwNDlkYzBmYjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.h9IQhn9LHsi63btIRwcOh_fxg0w8hpZcbt2kRCLfAcg)
Perhaps we could plot the primal and dual objective separately on a non log plot so we can see them even if they're negative? Or maybe just add to the text to explain what's happening.
The text was updated successfully, but these errors were encountered: